Use 'FromMaybe' variant of GetFunction()->NewInstance() #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecation warning Signed-off-by: Tim Janik <timj@gnu.org>
|
Well, this moving to So at the present I prefer not to break compatibility with older V8 versions, at least from version 4.10. I use preprocessor definitions But in general, you are right, and some time this should be done. |
pmed
added a commit
that referenced
this pull request
Feb 10, 2018
Updated implementation to V8 version 5.9: - use `v8::Local` instead of `v8::Handle` - use `v8::Global` instead of `v8::PersistentHandle` - use functions returning `MaybeLocal` Updated V8 versions in Travis script and Makefile, switched to `xenial` image (although it hasn't been officially released yet) Related to #50 and #66
pmed
added a commit
that referenced
this pull request
Feb 10, 2018
Updated implementation to V8 version 5.9: - use `v8::Local` instead of `v8::Handle` - use `v8::Global` instead of `v8::PersistentHandle` - use functions returning `MaybeLocal` Updated V8 versions in Travis script and Makefile, switched to `xenial` image (although it hasn't been officially released yet) Related to #50 and #66
pmed
added a commit
that referenced
this pull request
Feb 10, 2018
Updated implementation to V8 version 5.9: - use `v8::Local` instead of `v8::Handle` - use `v8::Global` instead of `v8::PersistentHandle` - use functions returning `MaybeLocal` Updated tests and examples. Updated V8 versions in Travis script and Makefile, switched to `xenial` image (although it hasn't been officially released yet) Related to #50 and #66
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid deprecation warning
Signed-off-by: Tim Janik timj@gnu.org